docs: remove finished TODO

peterxcli · Jan 15, 2024 · 6544d5e · 6544d5e
1 parent e2817a3
commit 6544d5e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 4 deletions.
diff --git a/pkg/controller/oauth_controller.go b/pkg/controller/oauth_controller.go
@@ -45,7 +45,6 @@ func (ctrl *OAuthController) LineLogin(c *gin.Context) {
 	log.Println("originalUrl:", originalUrl)
 	serverURL := ctrl.env.Line.ServerUrl
 	scope := "profile openid" //profile | openid | email
-	// TODO: add some random string to state
 	state := originalUrl + "$" + social.GenerateNonce()
 	if len(state) == 0 {
 		c.AbortWithStatusJSON(http.StatusBadRequest, model.Response{
@@ -83,7 +82,6 @@ func (ctrl *OAuthController) LineLoginCallback(c *gin.Context) {
 		return
 	}
 	log.Println("code:", code, " stateInCookie:", stateInCookie)
-	// TODO: remove the random string from state
 	frontendURL := strings.Split(stateInCookie, "$")[0]
 	token, err := ctrl.lineSocialClient.GetAccessToken(fmt.Sprintf("%s/line-login/callback", serverURL), code).Do()
 	if err != nil {

diff --git a/pkg/controller/user_controller.go b/pkg/controller/user_controller.go
@@ -103,8 +103,6 @@ func (ctrl *UserController) RefreshToken(c *gin.Context) {
 		return
 	}
 
-	// TODO: DO we need to check if the user is still active or any other things?
-
 	accessToken, err := ctrl.userSvc.CreateAccessToken(c, identity, ctrl.env.JWT.AccessTokenSecret, ctrl.env.JWT.AccessTokenExpiry)
 	if err != nil {
 		c.AbortWithStatusJSON(http.StatusInternalServerError, model.Response{