Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make statistics_info use catalog arg #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mohawk2
Copy link
Contributor

@mohawk2 mohawk2 commented Sep 18, 2024

Sorry for taking two goes at this. It was bothering me today that I saw the catalog info coming back from the db, but I knew statistics_info had filtering on that disabled. Now it's not (with a test, and everything!).

@dveeden
Copy link
Collaborator

dveeden commented Sep 19, 2024

As MySQL doesn't support catalogs, the name it returns is always def isn't it? Does it make sense to do filtering on that?

mysql-9.0.1> SELECT CATALOG_NAME FROM information_schema.schemata GROUP BY CATALOG_NAME;
+--------------+
| CATALOG_NAME |
+--------------+
| def          |
+--------------+
1 row in set (0.01 sec)

I know that there are plans to add catalog support to MariaDB, but that hasn't been merged yet.

@mohawk2
Copy link
Contributor Author

mohawk2 commented Sep 21, 2024

It seems to me that in that case this addition is harmless, and if someone uses this DBD for MariaDB (which I've heard of as a thing) after it gets catalogs, this addition would become valuable?

@mohawk2
Copy link
Contributor Author

mohawk2 commented Sep 21, 2024

By the way, your AppVeyor config looks broken - it's giving an error talking about not finding project files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants