PT-2378 - extended FP precision in pt-table-sync #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpoettker
force-pushed
the
PT-2378_table_sync_with_more_fp_precision
branch
from
c0f3c96 to
687f24b
Compare
|
I updated the PR such that the change is also included in This affected the source code of many tools. However, the only tool except for |
hpoettker
force-pushed
the
PT-2378_table_sync_with_more_fp_precision
branch
from
687f24b to
6cbe827
Compare
pt-table-sync now uses up to 17 decimal digits when writing floating point numbers in the generated SQL statements. This is necessary to prevent unintended data changes.
hpoettker
force-pushed
the
PT-2378_table_sync_with_more_fp_precision
branch
from
6cbe827 to
ad350a2
Compare
|
Thanks so much for the massive effort to adjust the code base to MySQL 8.4! I've rebased the changes on the latest commit in 3.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is intended to resolve this issue: https://perconadev.atlassian.net/browse/PT-2378
The tests added with
pt-2378.tall fail with the current code base. With the proposed change, they run successfully. They test that bothREPLACEandUPDATEstatements are generated bypt-table-syncsuch that floating point numbers that are not intended to change indeed don't change.The code is my own creation and it can be distributed under the GPL2 licence.