Everest-1717 | RBAC UI tests

.github/workflows/dev-fe-e2e.yaml

@@ -7,6 +7,10 @@ on:
         required: true
       CI_PASSWORD:
         required: true
+      RBAC_USER:
+        required: true
+      RBAC_PASSWORD:
+        required: true
 
 jobs:
   e2e:
@@ -148,6 +152,8 @@ jobs:
           EVEREST_LOCATION_URL: "https://minio.minio.svc.cluster.local"
           CI_USER: "admin"
           CI_PASSWORD: "${{ env.EVEREST_ADMIN_PASSWORD }}"
+          RBAC_USER: "rbac_user"
+          RBAC_PASSWORD: "rbac-e2e-test"
           MONITORING_USER: "admin"
           MONITORING_PASSWORD: "admin"
         run: |

.github/workflows/dev-fe-gatekeeper.yaml

@@ -129,6 +129,8 @@ jobs:
     secrets:
       CI_USER: everestadmin
       CI_PASSWORD: everestadmin
+      RBAC_USER: rbac_user
+      RBAC_PASSWORD: rbac-e2e-test
 
   merge-gatekeeper:
     needs: [CI_checks, permission_checks, E2E_tests_workflow]

ui/apps/everest/.e2e/.env.test

@@ -8,3 +8,5 @@ MONITORING_USER="<MONITORING_USER>"
 MONITORING_PASSWORD="<MONITORING_PASSWORD>"
 CI_USER="<CI_USER>"
 CI_PASSWORD="<CI_PASSWORD>"
+RBAC_USER="<RBAC_USER>"
+RBAC_PASSWORD="<RBAC_PASSWORD>"

ui/apps/everest/.e2e/.gitignore

@@ -1,3 +1,4 @@
 tests-out
 .env
 user.json
+old_rbac_permissions

ui/apps/everest/.e2e/playwright.config.ts

@@ -16,7 +16,7 @@ import { defineConfig } from '@playwright/test';
 import path from 'path';
 import { dirname } from 'path';
 import { fileURLToPath } from 'url';
-import { STORAGE_STATE_FILE, TIMEOUTS } from './constants';
+import { STORAGE_STATE_FILE } from './constants';
 import 'dotenv/config';
 
 // Convert 'import.meta.url' to the equivalent __filename and __dirname
@@ -67,13 +67,13 @@ export default defineConfig({
   /* Configure projects for major browsers */
   projects: [
     {
-      testDir: '.',
       name: 'auth',
+      testDir: './setup',
       testMatch: /auth.setup\.ts/,
     },
     {
-      testDir: '.',
       name: 'setup',
+      testDir: './setup',
       testMatch: /global.setup\.ts/,
       teardown: 'teardown',
       use: {
@@ -82,20 +82,49 @@ export default defineConfig({
       dependencies: ['auth'],
     },
     {
-      testDir: '.',
       name: 'teardown',
+      testDir: './teardown',
       use: {
         storageState: STORAGE_STATE_FILE,
       },
       testMatch: /global\.teardown\.ts/,
     },
+    {
+      name: 'rbac-setup',
+      testDir: './setup',
+      testMatch: /rbac.setup\.ts/,
+      use: {
+        storageState: STORAGE_STATE_FILE,
+      },
+      dependencies: ['setup'],
+    },
+    {
+      name: 'rbac',
+      use: {
+        browserName: 'chromium',
+        channel: 'chrome',
+        storageState: STORAGE_STATE_FILE,
+      },
+      testDir: './pr/rbac',
+      dependencies: ['setup', 'rbac-setup'],
+    },
+    {
+      name: 'rbac-teardown',
+      testDir: './teardown',
+      testMatch: /rbac\.teardown\.ts/,
+      use: {
+        storageState: STORAGE_STATE_FILE,
+      },
+      dependencies: ['rbac'],
+    },
     {
       name: 'pr',
       use: {
         storageState: STORAGE_STATE_FILE,
       },
       testDir: 'pr',
-      dependencies: ['setup'],
+      testIgnore: ['pr/rbac/**/*'],
+      dependencies: ['setup', 'rbac', 'rbac-teardown'],
     },
     {
       name: 'release',

ui/apps/everest/.e2e/pr/rbac/backups.e2e.ts

@@ -0,0 +1,123 @@
+import { getTokenFromLocalStorage } from '@e2e/utils/localStorage';
+import { getNamespacesFn } from '@e2e/utils/namespaces';
+import { setRBACPermissionsK8S } from '@e2e/utils/rbac-cmd-line';
+import { expect, test } from '@playwright/test';
+import {
+  MOCK_CLUSTER_NAME,
+  mockBackups,
+  mockClusters,
+  mockStorages,
+} from './utils';
+
+test.describe('Backups RBAC', () => {
+  let namespace = '';
+  test.beforeAll(async ({ request }) => {
+    const token = await getTokenFromLocalStorage();
+    const namespaces = await getNamespacesFn(token, request);
+    namespace = namespaces[0];
+    console.log('Namespace:', namespace);
+  });
+
+  test('Hide Backups', async ({ page }) => {
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['backup-storages', '*', `${namespace}/*`],
+      ['database-clusters', '*', `${namespace}/*`],
+    ]);
+    await mockClusters(page, namespace);
+    await mockBackups(page, namespace);
+    await mockStorages(page, namespace);
+    await page.goto(`/databases/${namespace}/${MOCK_CLUSTER_NAME}/backups`);
+    await expect(page.getByRole('table')).toBeVisible();
+    const rows = page.locator('.MuiTableRow-root:not(.MuiTableRow-head)');
+    expect(await rows.count()).toBe(0);
+  });
+
+  test('Show Backups', async ({ page }) => {
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['backup-storages', '*', `${namespace}/*`],
+      ['database-clusters', '*', `${namespace}/*`],
+      ['database-cluster-backups', 'read', `${namespace}/${MOCK_CLUSTER_NAME}`],
+    ]);
+    await mockClusters(page, namespace);
+    await mockBackups(page, namespace);
+    await mockStorages(page, namespace);
+    await page.goto(`/databases/${namespace}/${MOCK_CLUSTER_NAME}/backups`);
+    await expect(page.getByRole('table')).toBeVisible();
+    await expect(page.getByTestId('row-actions-menu-button')).not.toBeVisible();
+    const rows = page.locator('.MuiTableRow-root:not(.MuiTableRow-head)');
+    expect(await rows.count()).toBe(1);
+  });
+
+  test('Delete backup', async ({ page }) => {
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['backup-storages', '*', `${namespace}/*`],
+      ['database-clusters', '*', `${namespace}/*`],
+      ['database-cluster-backups', 'read', `${namespace}/${MOCK_CLUSTER_NAME}`],
+      [
+        'database-cluster-backups',
+        'delete',
+        `${namespace}/${MOCK_CLUSTER_NAME}`,
+      ],
+    ]);
+    await mockClusters(page, namespace);
+    await mockBackups(page, namespace);
+    await mockStorages(page, namespace);
+    await page.goto(`/databases/${namespace}/${MOCK_CLUSTER_NAME}/backups`);
+    await expect(page.getByTestId('row-actions-menu-button')).toBeVisible();
+    await page.getByTestId('row-actions-menu-button').click();
+    await expect(page.getByText('Delete')).toBeVisible();
+    await expect(page.getByText('Restore to this DB')).not.toBeVisible();
+    await expect(page.getByText('Create new DB')).not.toBeVisible();
+  });
+
+  test('Create on-demand backup', async ({ page }) => {
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['backup-storages', '*', `${namespace}/*`],
+      ['database-clusters', 'read', `${namespace}/*`],
+      [
+        'database-cluster-backups',
+        'create',
+        `${namespace}/${MOCK_CLUSTER_NAME}`,
+      ],
+    ]);
+    await mockClusters(page, namespace);
+    await mockBackups(page, namespace);
+    await mockStorages(page, namespace);
+    await page.goto(`/databases/${namespace}/${MOCK_CLUSTER_NAME}/backups`);
+    await expect(page.getByTestId('menu-button')).toBeVisible();
+    await page.getByText('Create backup').click();
+    await expect(page.getByText('Now', { exact: true })).toBeVisible();
+    await expect(page.getByText('Schedule', { exact: true })).not.toBeVisible();
+  });
+
+  test('Create scheduled backup', async ({ page }) => {
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['backup-storages', '*', `${namespace}/*`],
+      ['database-clusters', 'read', `${namespace}/*`],
+      ['database-clusters', 'update', `${namespace}/*`],
+      [
+        'database-cluster-backups',
+        'create',
+        `${namespace}/${MOCK_CLUSTER_NAME}`,
+      ],
+    ]);
+    await mockClusters(page, namespace);
+    await mockBackups(page, namespace);
+    await mockStorages(page, namespace);
+    await page.goto(`/databases/${namespace}/${MOCK_CLUSTER_NAME}/backups`);
+    await expect(page.getByTestId('menu-button')).toBeVisible();
+    await page.getByText('Create backup').click();
+    await expect(page.getByText('Schedule', { exact: true })).toBeVisible();
+  });
+});
+1;

ui/apps/everest/.e2e/pr/rbac/clusters.e2e.ts

@@ -0,0 +1,113 @@
+import { expect, test } from '@playwright/test';
+import { mockEngines, MOCK_CLUSTER_NAME, mockClusters } from './utils';
+import { getTokenFromLocalStorage } from '@e2e/utils/localStorage';
+import { getNamespacesFn } from '@e2e/utils/namespaces';
+import { setRBACPermissionsK8S } from '@e2e/utils/rbac-cmd-line';
+
+const { CI_USER: user } = process.env;
+
+test.describe('Clusters RBAC', () => {
+  let namespace = '';
+
+  test.beforeAll(async ({ request }) => {
+    const token = await getTokenFromLocalStorage();
+    const namespaces = await getNamespacesFn(token, request);
+    namespace = namespaces[0];
+  });
+
+  test('permitted cluster creation with present clusters', async ({ page }) => {
+    await mockEngines(page, namespace);
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['database-clusters', '*', `${namespace}/*`],
+    ]);
+    await mockClusters(page, namespace);
+    await page.goto('/databases');
+    await expect(page.getByText('Create database')).toBeVisible();
+    await expect(page.getByText('Create database')).not.toBeDisabled();
+  });
+
+  test('permitted cluster creation without present clusters', async ({
+    page,
+  }) => {
+    await mockEngines(page, namespace);
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['database-clusters', '*', `${namespace}/*`],
+    ]);
+    await page.goto('/databases');
+    await expect(page.getByText('Create database')).toBeVisible();
+    await expect(page.getByText('Create database')).not.toBeDisabled();
+  });
+
+  test('not permitted cluster creation with present clusters', async ({
+    page,
+  }) => {
+    await mockEngines(page, namespace);
+    await mockClusters(page, namespace);
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['database-clusters', 'read', `${namespace}/*`],
+    ]);
+    await page.goto('/databases');
+    await expect(page.getByText('Create database')).not.toBeVisible();
+  });
+
+  test('not permitted cluster creation without present clusters', async ({
+    page,
+  }) => {
+    await mockEngines(page, namespace);
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['database-clusters', 'read', `${namespace}/*`],
+    ]);
+    await page.goto('/databases');
+    await expect(page.getByText('Create database')).not.toBeVisible();
+  });
+
+  test('visible actions', async ({ page }) => {
+    await mockEngines(page, namespace);
+    await mockClusters(page, namespace);
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['database-clusters', '*', `${namespace}/${MOCK_CLUSTER_NAME}`],
+    ]);
+    await page.goto('/databases');
+    await page.getByTestId('actions-menu-button').click();
+    await expect(page.getByText('Delete')).toBeVisible();
+    await expect(page.getByText('Suspend')).toBeVisible();
+    await expect(page.getByText('Restart')).toBeVisible();
+
+    await page.goto(`/databases/${namespace}/${MOCK_CLUSTER_NAME}`);
+    await expect(
+      page.getByTestId('edit-advanced-configuration-db-btn')
+    ).toBeVisible();
+    await expect(
+      page.getByTestId('edit-advanced-configuration-db-btn')
+    ).not.toBeDisabled();
+    await expect(page.getByTestId('edit-resources-button')).toBeVisible();
+    await expect(page.getByTestId('edit-resources-button')).not.toBeDisabled();
+  });
+
+  test('not visible actions', async ({ page }) => {
+    await mockEngines(page, namespace);
+    await mockClusters(page, namespace);
+    await setRBACPermissionsK8S([
+      ['namespaces', 'read', namespace],
+      ['database-engines', '*', `${namespace}/*`],
+      ['database-clusters', 'read', `${namespace}/${MOCK_CLUSTER_NAME}`],
+    ]);
+    await page.goto('/databases');
+    await expect(page.getByTestId('actions-menu-button')).not.toBeVisible();
+    await page.goto(`/databases/${namespace}/${MOCK_CLUSTER_NAME}`);
+    await expect(
+      page.getByTestId('edit-advanced-configuration-db-btn')
+    ).not.toBeVisible();
+    await expect(page.getByTestId('edit-resources-button')).toBeDisabled();
+  });
+});