EVEREST-107 run e2e tests conditionally #605
Open
+1,292
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recharte
force-pushed
the
EVEREST-107-tests-reorg
branch
3 times, most recently
from
2b3c765 to
bde0eff
Compare
recharte
added
test/e2e-upgrade
recharte
force-pushed
the
EVEREST-107-tests-reorg
branch
2 times, most recently
from
69b2812 to
4b522ec
Compare
By making the EKS E2E tests optional we need some more integration tests to ensure some basic sanity on every PR.
recharte
force-pushed
the
EVEREST-107-tests-reorg
branch
from
4b522ec to
6801227
Compare
The dbengine tests upgrade the CRDs which sometimes messes up other tests, running them on a separate step isolates them from the other tests.
recharte
requested review from
oksana-grishchenko and
mayankshah1607
as code owners
| @@ -46,9 +47,82 @@ jobs: | |||
| PG_OPERATOR_VERSION: 2.5.0 | |||
| PERCONA_VERSION_SERVICE_URL: https://check-dev.percona.com/versions/v1 | |||
|
|
|||
| integration-tests: | |||
There was a problem hiding this comment.
I was expecting a step to run kind create cluster ..., but that's not there. When does the kind cluster get created? 🤔
mayankshah1607
approved these changes
Dec 19, 2024
|
|
||
| eks-e2e-tests: | ||
| name: E2E tests (EKS) | ||
| if: contains(github.event.pull_request.labels.*.name, 'test/e2e') || contains(github.event.pull_request.labels.*.name, 'test/e2e-upgrade') || contains(github.event.pull_request.labels.*.name, 'test/e2e-core') |
There was a problem hiding this comment.
The E2E step is a required check in CI, so we skip it, the PR will be blocked, wouldn't it? Should we configure Merge Gatekeeper then?
There was a problem hiding this comment.
Although now it looks like the PR is not blocked by the skipped step. Not sure😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The E2E test suite takes a long time to run and these tests are not always needed.
This PR introduces a condition for running the E2E test suite based on PR labels. There are 3 labels relevant:
test/e2e- runs the full e2e test suite (core+upgrade)test/e2e-core- runs just the core e2e test suitetest/e2e-upgrade- runs just the upgrade e2e test suiteBesides the conditional run of E2E tests, this PR introduces some more changes to the integration tests: