Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Approval history UI #746

Merged
merged 7 commits into from
Nov 13, 2024
Merged

Approval history UI #746

merged 7 commits into from
Nov 13, 2024

Conversation

julianweng
Copy link
Member

Allows site admins and associated leaders to view a club's approval history.

Club home page list of approvals/rejections/submissions

Collapsed view

Expanded reason modal

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (618b65c) to head (3993a51).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
backend/clubs/serializers.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   71.88%   71.94%   +0.05%     
==========================================
  Files          32       32              
  Lines        6933     6950      +17     
==========================================
+ Hits         4984     5000      +16     
- Misses       1949     1950       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a sick feature, thanks for taking the initiative on this. LGTM outside of a couple comments.

backend/clubs/views.py Outdated Show resolved Hide resolved
backend/clubs/views.py Show resolved Hide resolved
Copy link
Member

@rm03 rm03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Julian, good work

backend/clubs/serializers.py Outdated Show resolved Hide resolved
@julianweng julianweng merged commit b280dc0 into master Nov 13, 2024
8 checks passed
@julianweng julianweng deleted the approval-history-ui branch November 13, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants