Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move graduate_users script to cronjob #730

Merged
merged 4 commits into from
Sep 30, 2024
Merged

Move graduate_users script to cronjob #730

merged 4 commits into from
Sep 30, 2024

Conversation

rm03
Copy link
Member

@rm03 rm03 commented Sep 28, 2024

The graduate_users script, which deactivates memberships for users who graduated before the current year, was originally intended to be executed manually via the admin console. Since this task should occur automatically at the beginning of each year, it makes more sense to have the script as a cronjob.

Copy link
Member

@aviupadhyayula aviupadhyayula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Rohan. Would love to see a unit test for this command.

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.47%. Comparing base (9612017) to head (f963183).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #730      +/-   ##
==========================================
+ Coverage   71.37%   71.47%   +0.09%     
==========================================
  Files          31       31              
  Lines        6848     6847       -1     
==========================================
+ Hits         4888     4894       +6     
+ Misses       1960     1953       -7     
Flag Coverage Δ
71.47% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rm03 rm03 merged commit d3c7c9c into master Sep 30, 2024
6 of 7 checks passed
@rm03 rm03 deleted the grad-users branch September 30, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants