Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip-feature: Allow resend of acceptance/rejection emails #592

Merged
merged 4 commits into from
Oct 2, 2023

Conversation

aviupadhyayula
Copy link
Member

@aviupadhyayula aviupadhyayula commented Sep 26, 2023

Creates an option for club admins to resend all acceptance/rejection emails, regardless of whether applicants have been previously notified or not. Resolves #585.

Still a WIP. To-do:

  • Add tests
  • Create stronger checks against people accidentally pressing this. Maybe we can add a pop-up or change the helpText to deter admins resending emails without good reason to. (CC'ing @julianweng)

What it looks like:
Screenshot 2023-09-25 at 11 38 18 PM

@rohangpta
Copy link
Member

rohangpta commented Sep 27, 2023

Can we get a review @julianweng @esinx @rm03? You can assign yourselves as reviewers on the top right and leave some comments where appropriate.

Would be lovely to get you all some practice with reviewing code :)

@rohangpta rohangpta self-assigned this Sep 27, 2023
@esinx esinx self-requested a review October 1, 2023 23:25
Copy link
Member

@esinx esinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Might be an unrelated question, but are we somehow tracking which mails have been sent at what time? Might be useful to display a log of what mails have been sent through Penn Clubs.

@esinx
Copy link
Member

esinx commented Oct 1, 2023

@aviupadhyayula please feel free to merge whenever you feel comfortable about this PR!

@aviupadhyayula
Copy link
Member Author

Might be an unrelated question, but are we somehow tracking which mails have been sent at what time? Might be useful to display a log of what mails have been sent through Penn Clubs.

Not that I know of, but this seems easy enough to implement. We could create a wrapper class around each email and append it to some global array. An alternative is using some package like django-mailer, which would store outgoing emails in a database.

Is there any reason we'd need this functionality? Can look into it with future PRs.

@aviupadhyayula aviupadhyayula merged commit caf576f into master Oct 2, 2023
7 checks passed
@aviupadhyayula aviupadhyayula deleted the feature-allow-acceptance-resend branch October 2, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Allow admins to resend acceptance/rejection emails to applicants
4 participants