Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to fontbox 3.0.2 #349

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

upgrade to fontbox 3.0.2 #349

wants to merge 1 commit into from

Conversation

myroch
Copy link

@myroch myroch commented Apr 9, 2024

  • sync gradle and maven versions
  • upgrade bouncycastle to 1.78

@pcorless
Copy link
Owner

I've had some trouble with the early version of fontbox 3 passing the QA suite. I'll give it another got and let you know how it goes. Is there anything thing 3.0.2 you are in need of, fixes some rendering issue?

@myroch
Copy link
Author

myroch commented Apr 10, 2024

All jUnits were green, so I hope it will work for you this time. There are definitely some fontbox corrections: https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310760&version=12353972
I need pdfbox 3.x as we are already on jakarta, so we don't have javax xml bind API anymore. And there should be more fancy stuff in pdfbox 3 as well (writting compressed pdfs as per default, reduced memory usage usw.)

@pcorless
Copy link
Owner

This library only uses the font-box library to read and render glyphs in fonts. I ran the changes thought the more intense QA test suite I have to test rendering regressions and there are still issues with large chunk of my test suite.
image
I"ll need to dig into these font rendering issues to see what's change in the font-box library and figure out why some many glyphs are corrupted. Hopefully it's nothing to crazy as I would like to keep the libraries up to date.

@pcorless
Copy link
Owner

Looks like the root of the issue is a ConcurrentModificationException. The 2.x version of the library seemed to be a little more thread safe. I'll see what I can do to address this.

@myroch
Copy link
Author

myroch commented Apr 18, 2024

ok, I guess PDF rendering, resp. font rendering should happen in single thread only. Hopefully just a test issue.

@pcorless pcorless changed the title upgrade to pdfbox 3.0.2 upgrade to fontbox 3.0.2 May 4, 2024
@pcorless
Copy link
Owner

pcorless commented May 8, 2024

Started a conversation with the fontbox people about the regression. I'll keep you posted on how it goes.

@pcorless
Copy link
Owner

Managed to contact the folks over at fontbox and they have prepped a fix for the issue, https://issues.apache.org/jira/browse/PDFBOX-5819 Should be available in 3.0.3 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants