Fix for Issue #388 which broke executable reproducibility #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
setup. Links for other mainfests weren't created if scaninputs=True. Modified existing test to trigger error. Test now passes.
|
Hello @aidanheerdegen! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2023-11-29 08:57:50 UTC |
|
Hey @jo-basevi. I know you're super busy, but this is one of the fixes I'd like to get in before we merge the UUID/clone/branch stuff so would appreciate a review. It shouldn't be a big deal, as it is a pretty simple fix for a fairly obvious error (mine as it turns out). |
jo-basevi
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #388 which caused executable reproducibility to break in some situations.
Bug was due to a
breakrather thancontinueinManifest.setup(). Links for other mainfests weren't created ifscaninputs=True.Modified existing test to trigger error. Test now passes.