Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in set_counter #370

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Fix bug in set_counter #370

merged 1 commit into from
Oct 4, 2023

Conversation

jo-basevi
Copy link
Collaborator

Explicitly check for None in set_counter if-statements, to set counter correctly when max restart/output index is 0

Should close #369

@coveralls
Copy link

Coverage Status

coverage: 42.053%. remained the same when pulling dfe86a4 on jo-basevi:369-set-counter-bug-fix into fc83ec9 on payu-org:master.

aidanheerdegen
aidanheerdegen approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jo-basevi jo-basevi merged commit c1db6dc into payu-org:master Oct 4, 2023
8 checks passed
@jo-basevi jo-basevi deleted the 369-set-counter-bug-fix branch October 4, 2023 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aidanheerdegen aidanheerdegen aidanheerdegen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug in set_counter
3 participants
@jo-basevi @coveralls @aidanheerdegen