-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pypi build and publish to CD #362
Conversation
Seeing as I managed to accidentally publish 1.0.19 to PyPI I guess that bit actually works. 😆 https://pypi.org/project/payu/1.0.19/ I'll leave that published version up, as we currently have no candidate for a tagged release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments/questions
Also, is there any value in having the conda build use the PyPI dist, e.g. here? This ensures that the PyPI and conda dists are always the same (though I don't know how they wouldn't be...) and makes the conda build dependent on a successful PyPI build (which could be seen as good or bad...)
Thanks for the review. Lots of good feedback.
Probably there is yes, though this is mostly about not having a completely out of date version on PyPI, but that is not intended to be the official distribution channel. Having said which, I always found it confusing that Not sure I am the person to do that, so someone else** could either make those changes in this PR, or make a subsequent PR to align them. |
Let's merge this since it does the job (hopefully), and maybe leave that for another PR? |
Co-authored-by: Aidan Heerdegen <[email protected]>
Add automated PyPI publishing to CD Workflow.
Closes #361