Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pypi build and publish to CD #362

Merged
merged 5 commits into from
Sep 14, 2023
Merged

Conversation

aidanheerdegen
Copy link
Collaborator

Add automated PyPI publishing to CD Workflow.

Closes #361

@coveralls
Copy link

coveralls commented Sep 12, 2023

Coverage Status

coverage: 42.016%. remained the same when pulling 8b44917 on aidanheerdegen/issue361 into 6a1d1de on master.

@aidanheerdegen
Copy link
Collaborator Author

aidanheerdegen commented Sep 12, 2023

Seeing as I managed to accidentally publish 1.0.19 to PyPI I guess that bit actually works. 😆

https://pypi.org/project/payu/1.0.19/

I'll leave that published version up, as we currently have no candidate for a tagged release.

Copy link
Collaborator

@dougiesquire dougiesquire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments/questions

Also, is there any value in having the conda build use the PyPI dist, e.g. here? This ensures that the PyPI and conda dists are always the same (though I don't know how they wouldn't be...) and makes the conda build dependent on a successful PyPI build (which could be seen as good or bad...)

.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
.github/workflows/CD.yml Outdated Show resolved Hide resolved
@aidanheerdegen
Copy link
Collaborator Author

Thanks for the review. Lots of good feedback.

Also, is there any value in having the conda build use the PyPI dist

Probably there is yes, though this is mostly about not having a completely out of date version on PyPI, but that is not intended to be the official distribution channel.

Having said which, I always found it confusing that conda and pip install seemed to use slightly different, but overlapping, configuration/meta-data. If they can be made to be completely compatible then yeah, probably a good idea.

Not sure I am the person to do that, so someone else** could either make those changes in this PR, or make a subsequent PR to align them.

** @dougiesquire

@dougiesquire
Copy link
Collaborator

could either make those changes in this PR, or make a subsequent PR to align them

Let's merge this since it does the job (hopefully), and maybe leave that for another PR?

@aidanheerdegen aidanheerdegen merged commit 2d16f18 into master Sep 14, 2023
11 checks passed
@aidanheerdegen aidanheerdegen deleted the aidanheerdegen/issue361 branch September 14, 2023 01:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove payu from pypi?
3 participants