Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: graphql query concurrency issues #6925

Merged
merged 8 commits into from
Jul 8, 2024
Merged

Conversation

PatrikKozak
Copy link
Contributor

@PatrikKozak PatrikKozak commented Jun 25, 2024

Description

This is the beta (v3) PR for the v2 PR here

Addresses #6800, #5108

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes

@denolfe denolfe changed the title fix(payload): #6800, #5108 - graphql query concurrency issues fix: graphql query concurrency issues Jun 25, 2024
@yobottehg
Copy link

Any chance to get this in? We currently have inconsistent GraphQL responses which makes development a bit tedious.

@yobottehg
Copy link

yobottehg commented Jul 4, 2024

I just wanted to add that these changes here in the PR applied against beta.58 via patch-package solve both problems we currently have with payload graphql:

  1. concurrent requests can fail
  2. some requested relations will randomly be empty on requests. See also the Discord discussion regarding this: https://discord.com/channels/967097582721572934/1209342986610024468

@jmikrut jmikrut enabled auto-merge (squash) July 8, 2024 14:24
@jmikrut jmikrut merged commit fb72d19 into beta Jul 8, 2024
44 checks passed
@jmikrut jmikrut deleted the fix/beta/graphql-concurrency branch July 8, 2024 15:55
paulpopus pushed a commit that referenced this pull request Jul 24, 2024
## Description

This is the beta (v3) PR for the v2 PR
[here](#6857)

Addresses #6800, #5108

- [x] I have read and understand the
[CONTRIBUTING.md](https://github.com/payloadcms/payload/blob/main/CONTRIBUTING.md)
document in this repository.

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)

## Checklist:

- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] Existing test suite passes locally with my changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants