Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): prevents perPage blink #10238

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

jacobsfletch
Copy link
Member

@jacobsfletch jacobsfletch commented Dec 30, 2024

When defining a custom admin.pagination.defaultLimit, the PerPage component would blink in the base sanitization values before being replaced by the proper values defined in the config (if no limit preference set and no ?page= in search params). This was because the list view was relying on the client config to be propagated through React context before those values could be read, requiring an entire rendering cycle before this takes place.

@jacobsfletch jacobsfletch changed the title chore(ui): prevents perPage blink and adds custom pagination tests fix(ui): prevents perPage blink Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant