Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Estonian language support #10169

Merged
merged 8 commits into from
Jan 2, 2025
Merged

feat: add Estonian language support #10169

merged 8 commits into from
Jan 2, 2025
+611 −1

Conversation

tristankrass
Copy link
Contributor

@tristankrass tristankrass commented Dec 25, 2024 •
edited
Loading

Adding Estonian language support for the Payload CMS.

DanRibbens
DanRibbens requested changes Dec 27, 2024
View reviewed changes
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can't be merged until we resolve all the undefined values for sl translations.

@tristankrass
Copy link
Contributor Author

This can't be merged until we resolve all the undefined values for sl translations.

@DanRibbens Added missing Slovenian translations.

DanRibbens
DanRibbens requested changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the build is still failing.
https://github.com/payloadcms/payload/actions/runs/12526676553/job/34940626950#step:4:29

Are you able to build locally?

@tristankrass
Copy link
Contributor Author

Looks like the build is still failing. payloadcms/payload/actions/runs/12526676553/job/34940626950#step:4:29

Are you able to build locally?

Running pnpm run build:all yields following result: (Everything looks like it's working)


 Tasks:    32 successful, 32 total
Cached:    0 cached, 32 total
  Time:    1m20.397s

@tristankrass
Copy link
Contributor Author

Any guidance, how to proceed?

DanRibbens
DanRibbens approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to add a few Estonian keys that have been added since your PR that were preventing the build from succeeding.
This should be ready to merge now. Thanks @tristankrass!

@DanRibbens DanRibbens enabled auto-merge (squash) January 2, 2025 19:28
@DanRibbens DanRibbens merged commit 38f3455 into payloadcms:main Jan 2, 2025
68 checks passed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

🚀 This is included in version v3.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanRibbens DanRibbens DanRibbens approved these changes

@denolfe denolfe Awaiting requested review from denolfe denolfe is a code owner

@jmikrut jmikrut Awaiting requested review from jmikrut jmikrut is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tristankrass @DanRibbens