-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ui): disable save button until the upload file is uploaded / ready #10083
Conversation
…t to the Submit button
…-from-url-disabled-save
…-from-url-disabled-save
…-from-url-disabled-save
…-from-url-disabled-save
…-from-url-disabled-save
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason we wouldn't want to add the upload status to the existing DocumentInfoProvider? I don't see what we gain by adding another provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than adding the same logic for disabled state, you should pass the forceDisabled prop down. That way custom components all continue to work without having to make this same exact change also.
🚀 This is included in version v3.14.0 |
What?
Previously, while uploading a file - if the uploading process took a bit of time, users could still save the document prior to the upload fully completing.
Why?
During the uploading process - the save button should be disabled until the upload is complete to prevent premature saving of an upload document.
How?
Now, we keep track of the state of the upload in a provider and disable the save button until the file is fully uploaded.