Use bitcoin-ffi types instead of our own bitcoin module.
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanGould
force-pushed
the
bitcoin-ffi
branch
from
3157eb4
to
deb22b0
Compare
DanGould
force-pushed
the
bitcoin-ffi
branch
from
deb22b0
to
8f68410
Compare
DanGould
force-pushed
the
bitcoin-ffi
branch
from
8f68410
to
def813d
Compare
spacebear21
reviewed
Nov 27, 2024
Comment on lines
+387
to
+388
| pub fn utxos_to_be_locked(&self) -> Vec<crate::OutPoint> { | ||
| let mut outpoints: Vec<crate::OutPoint> = Vec::new(); |
There was a problem hiding this comment.
OutPoint is imported from crate::bitcoin_ffi, why the crate modifier?
Import types from UDL and re-export as bitcoin_ffi to replace the bitcoin module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes depend on bitcoin-ffi proc macrosThese changes import bitcoin-ffi using
uniffi::use_udl_object!, but proc macros would obsolete these lines.We still have an incomplete but effective
PsbtInputtype in ourbitcoinmodule, but everything else works.close #3