Merge pull request #379 from paulmillr/promise-checks

[Fix] Add missing checks to `Promise.resolve` and `Promise.reject`
paulmillr · Dec 13, 2015 · 42c0217 · 42c0217
2 parents 20d978a + c8a69f9
commit 42c0217
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/es6-shim.js b/es6-shim.js
@@ -2316,6 +2316,9 @@
 
       reject: function reject(reason) {
         var C = this;
+        if (!ES.TypeIsObject(C)) {
+          throw new TypeError('Bad promise constructor');
+        }
         var capability = new PromiseCapability(C);
         var rejectFunc = capability.reject;
         rejectFunc(reason); // call with this===undefined
@@ -2325,6 +2328,9 @@
       resolve: function resolve(v) {
         // See https://esdiscuss.org/topic/fixing-promise-resolve for spec
         var C = this;
+        if (!ES.TypeIsObject(C)) {
+          throw new TypeError('Bad promise constructor');
+        }
         if (ES.IsPromise(v)) {
           var constructor = v.constructor;
           if (constructor === C) { return v; }