Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Atcore-app with atcore #4

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sithlord48
Copy link
Contributor

Connect button will now connect (needs https://phabricator.kde.org/D7759)

Signed-off-by: Chris Rizzitello [email protected]

Copy link
Owner

@patrickelectric patrickelectric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test this on android ?

main.cpp Outdated

Q_DECL_EXPORT int main(int argc, char *argv[])
{
QGuiApplication::setAttribute(Qt::AA_EnableHighDpiScaling);

QApplication app(argc, argv);

qmlRegisterType<AtCore>("org.kde.atcore",1,0,"AtCore");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Space after commas.

main.qml Outdated Show resolved Hide resolved
@sithlord48
Copy link
Contributor Author

sithlord48 commented Sep 21, 2017

where is our style file ?
i'll adjust these asap
If you can build on android i can test it , i can't build for android atm

@patrickelectric
Copy link
Owner

I think that would be better to merge this in other branch, I am finishing a better interface, please hold on.

@patrickelectric
Copy link
Owner

@sithlord48 you have done a merge and not a rebase, please, rebase your branch and remove the merge commit.

Connect button will now connect (needs https://phabricator.kde.org/D7759)

Signed-off-by: Chris Rizzitello <[email protected]>
…portSpeeds to populate the boxes. Set basic

layout adjustment for sizing

Signed-off-by: Chris Rizzitello <[email protected]>
@patrickelectric
Copy link
Owner

@sithlord48 very good, tys.
I'll test here first, and than I will merge it.

Add support for onPortsChanged to populate the device combo

Signed-off-by: Chris Rizzitello <[email protected]>
@patrickelectric
Copy link
Owner

Ok, after the new patche merge in atcore master, it was possible to compile it.
As you can see, you have changed some things that broke the gui, please, take a look on it.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants