Rework "Trusted networks" to be a generic "On-demand" #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop onDemand.disconnectsIfNotMatching on the way.
keeshux
commented
Jul 30, 2023
| public var policy: Policy = .excluding | ||
|
|
||
| public var withSSIDs: [String: Bool] = [:] | ||
|
|
||
| public var withOtherNetworks: Set<OtherNetwork> = [] | ||
|
|
||
| public var disconnectsIfNotMatching = true |
There was a problem hiding this comment.
Dropping this prevented downgrade from 2.2.0
See #338 for explanations.
keeshux
added a commit
that referenced
this pull request
Jul 30, 2023
In #333, the non-optional field `disconnectsIfNotMatching` was removed completely. Therefore, downgrading from 2.2.0 may lose profiles due to the missing required field. Mitigate the issue by restoring the field as optional, even if it's unused, for the sake of not breaking profile serialization until the 2.2.0 release. Remove the deprecated field after that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the feature by also providing a complementary "include" policy, i.e. activate the VPN only on the specified networks. "Trusted networks" was only providing the "exclude" counterpart, i.e. except the specified networks.
Closes #119