Implement facelist property #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pasbi
force-pushed
the
implement-facelist-property
branch
from
d7189e4 to
4e8cb3a
Compare
added 15 commits
March 30, 2022 23:45
# Conflicts: # src/properties/splineproperty.cpp # src/properties/splineproperty.h # src/serializers/abstractserializer.h # src/serializers/jsonserializer.cpp # src/serializers/jsonserializer.h
That requires some re-implementation of QPainterPath features, like `constains`. The usage of `QPainterPath::operator-` has been replaced by `Face::operator^` because it's easier to implement and gives the same result if one path contains the other.
# Conflicts: # src/path/face.cpp # src/path/face.h # src/properties/CMakeLists.txt # src/properties/splineproperty.cpp # src/propertytypeenum.h # src/renderers/offscreenrenderer.cpp # src/variant.h
pasbi
force-pushed
the
implement-facelist-property
branch
from
4c3284c to
c53cce5
Compare
added 9 commits
April 2, 2022 18:45
improves error messages if it's used in the wrong way.
don't expect options parameter, options are the same for all tests.
added 7 commits
April 7, 2022 16:24
Face operator^ is principally impossible to implement because edges don't have an identity (there might be multiple indistinguishable edges between two points). Therefore, PathVector::faces is simpler now. It's still not correct, but the (now removed) complicated implementation (employing operator^) wouldn't make it better. Simple and wrong is better than complicated and wrong. Fixing it properly probably requires a complete change of paradigms (i.e., identifiable edges)
That's going to be fixed on another branch `edge-identity`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.