Small directory structure change + external configurability #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might require some cleaning up since i see the LICENSE file being removed and you have added your own changelog notes. The .gitignore seems to be removed as well. I would suggest:
|
straccio
pushed a commit
to straccio/spark-protocol
that referenced
this pull request
Jun 13, 2017
straccio
pushed a commit
to straccio/spark-protocol
that referenced
this pull request
Jul 6, 2017
Include Update from Brewskey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a proposal to change the directory structure to make specific commits linkable via URL in dependency definitions for easier package development.
It also makes all settings overridable in the server constructor, fixing #3 on the way by letting you freely define where the server key should be stored.
It would be cool if you could merge this in — This would allow me to share further fixes and features via pull requests easily.
What do you think?