chore/sc-132686/update-device-constants #781
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomontero
changed the title
monkbroc
approved these changes
Dec 10, 2024
| "@particle/device-constants": "^3.5.0", | ||
| "binary-version-reader": "^2.5.1", | ||
| "@particle/device-constants": "^3.6.0", | ||
| "binary-version-reader": "^2.5.2", |
There was a problem hiding this comment.
We shouldn't bump binary-version-reader when updating device-constants. The point of having device-constants as a peer dependency in binary-version-reader is to avoid updating dependencies transiently. Only the top-level application has to update device-constants.
No need to undo it here, but no need to update in other applications.
hugomontero
force-pushed
the
chore/sc-132686/update-device-constants
branch
from
2d2d31a to
f7d98fa
Compare
hugomontero
force-pushed
the
chore/sc-132686/update-device-constants
branch
from
f7d98fa to
9b67f85
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update device-constants with new platform.
Discussions
Story details: https://app.shortcut.com/particle/story/132694/create-electron2-platform-in-cloud-services