Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate file used with enable-device-protection #750

Conversation

keeramis
Copy link
Contributor

Description

This PR checks if the file provided to the particle binary enable-device-protection supports Device Protection. If not, error is thrown.

How to Test

particle binary enable-device-protection /path/to/bootloader-6.0.0.bin -> works
particle binary enable-device-protection /path/to/pre-bootloader-6.0.0.bin -> errors
particle binary enable-device-protection /path/to/bootloader-5.8.0.bin -> errors
particle binary enable-device-protection /path/to/system-part-6.0.0.bin -> errors

Related Issues / Discussions

NA

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA
  • Problem and solution clearly stated
  • Tests have been provided
  • Docs have been updated
  • CI is passing

@keeramis keeramis changed the title Validate file used to turn to a protected version Validate file used with enable-device-protection Jun 28, 2024
@keeramis keeramis changed the base branch from master to feature/device-protection June 28, 2024 23:56
@keeramis keeramis requested a review from monkbroc June 29, 2024 00:11
@keeramis keeramis marked this pull request as ready for review June 29, 2024 00:11
@keeramis keeramis merged commit c0a1221 into feature/device-protection Jul 1, 2024
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants