use serial identify in case the device does not support control request #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugomontero
force-pushed
the
bug/sc-127690/imei-missing-from-particle-identify
branch
from
afbf65f
to
f153515
Compare
monkbroc
approved these changes
May 9, 2024
keeramis
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will add compatibility for
serial identifyin order to be used by older DVOS.This will allow us to retrieve again IMEI and ICCID for cellular devices
How to Test
git pull && git checkout bug/sc-127690/imei-missing-from-particle-identifynpm inpm start -- serial identifyon this follow platforms/DVOS:outcome
In every test you will be able to see the IMEI and ICCID data as part of the printed device info
Related Issues / Discussions
Story details: https://app.shortcut.com/particle/story/127690
Completeness