Skip to content

Commit

Permalink
Merge pull request #734 from particle-iot/chore/update-device-constan…
Browse files Browse the repository at this point in the history
…ts-and-platform-name

Support mono builds for rtk platforms and modify platform names
  • Loading branch information
keeramis authored May 15, 2024
2 parents 66817ef + 4f1ca3c commit 75de28d
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 16 deletions.
14 changes: 7 additions & 7 deletions npm-shrinkwrap.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
}
],
"dependencies": {
"@particle/device-constants": "^3.3.0",
"@particle/device-constants": "^3.4.0",
"binary-version-reader": "^2.3.1",
"chalk": "^2.4.2",
"cli-progress": "^3.12.0",
Expand Down
6 changes: 3 additions & 3 deletions src/lib/flash-helper.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,7 @@ describe('flash-helper', () => {
expect(mode).to.deep.equal({ flashMode: 'NORMAL', platformId: 26 });
});

it ('returns an error for mono builds', async() => {
it ('supports mono builds on rtk platforms', async() => {
const p2PlatformId = 32;
const file = await createBinary(ModuleInfo.FunctionType.MONO_FIRMWARE, p2PlatformId);
let error;
Expand All @@ -588,8 +588,8 @@ describe('flash-helper', () => {
} catch (e) {
error = e;
}
expect(error).to.be.an.instanceOf(Error);
expect(error).to.have.property('message', 'Module type monoFirmware unsupported for p2');

expect(error).to.be.undefined;
});
});

Expand Down
10 changes: 5 additions & 5 deletions src/lib/utilities.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,13 @@ describe('Utilities', () => {
12: 'Argon',
13: 'Boron',
14: 'Xenon',
15: 'E SoM X',
23: 'B SoM',
25: 'B5 SoM',
15: 'E-SoM-X',
23: 'B-SoM',
25: 'B5-SoM',
26: 'Asset Tracker / Monitor One',
28: 'Tracker M',
28: 'Tracker-M',
32: 'Photon 2 / P2',
35: 'M SoM'
35: 'M-SoM'
});
});
});
Expand Down

0 comments on commit 75de28d

Please sign in to comment.