-
Notifications
You must be signed in to change notification settings - Fork 513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[boron|bsom] u-blox R510 FOTA over HTTPS support #2358
base: develop-4.x
Are you sure you want to change the base?
Conversation
c960d0c
to
6afbd81
Compare
545fa28
to
8d591c0
Compare
8d591c0
to
89d39b8
Compare
89d39b8
to
0e2f5db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is quite a lot of complexity here and since things are not that tightly coupled to NCP client or other subsystems, it would be really nice to see unit tests for this. cellular_command()
, callbacks, system
methods and other dependent functions can easily be mocked and we can validate all the steps under various conditions.
For the moment I have reverted renaming the files to make viewing changes easier. This is a TODO for me to go back and rename ncp_fw_update.cpp/.h to sara_ncp_fw_update.cpp/.h |
3c678a4
to
33ff8bf
Compare
16a5c06
to
ae61beb
Compare
02d203d
to
e36500c
Compare
6b634a8
to
9d4d141
Compare
9d4d141
to
1296304
Compare
1296304
to
faf307c
Compare
faf307c
to
8f4a7c8
Compare
c761976
to
5526632
Compare
e1df053
to
8646a46
Compare
8646a46
to
d611b47
Compare
d611b47
to
a1a35cf
Compare
…re/SARA-R510-NCP-FW-update) Author: Technobly <[email protected]> Date: Wed Dec 15 16:26:50 2021 -0600 reduce specificity of expected publishEvent calls commit c9d846b Author: Technobly <[email protected]> Date: Wed Dec 15 13:24:25 2021 -0600 update CI unit tests to output verbose logs on failure commit 62c8fd9 Author: Technobly <[email protected]> Date: Tue Dec 14 13:17:39 2021 -0600 addresses final PR comments - Adds SaraNcpFwUpdateLock to make user interfaces thread-safe - Fixes issue with sUrcHandlers not retaining unique pointers - Allows cellular disconnect timeouts to proceed - Adds cellular_lock() before accessing variables used in urcHandlers - Fixes errors with comm. unit_tests caused by some initial code added for ncp_fw_update testing - Moves all NCPFW_LOG statements during SAFE_MODE to NCPFW_LOG_DEBUG to reduce size commit b509fbf Author: Technobly <[email protected]> Date: Fri Dec 10 22:42:52 2021 -0600 adds system_errors and diagnostics commit ac13d10 Author: Technobly <[email protected]> Date: Tue Nov 30 23:20:27 2021 -0600 adds SaraNcpFwUpdate unit tests commit 41f4093 Author: Technobly <[email protected]> Date: Mon Nov 22 23:19:58 2021 -0600 [hal] cellular add/remove urc handler commit 7c0d8f9 Author: Technobly <[email protected]> Date: Mon Nov 15 12:21:38 2021 -0600 skeleton for SaraNcpFwUpdate unit tests commit 5bb6334 Author: Technobly <[email protected]> Date: Fri Oct 29 20:59:23 2021 -0500 addresses most PR comments commit d22aaf6 Author: Technobly <[email protected]> Date: Fri Oct 22 15:13:34 2021 -0500 prevent a dependency issue causing a safe mode loop commit f762226 Author: Technobly <[email protected]> Date: Thu Sep 30 10:36:21 2021 -0500 Implements background modem update checks, Cellular.updateStatus(), Cellular.enableUpdates() commit 3d09a76 Author: Technobly <[email protected]> Date: Wed Sep 29 13:27:24 2021 -0500 rebase and whitespace fixes commit 6c2f5e9 Author: Technobly <[email protected]> Date: Mon Sep 27 10:34:43 2021 -0500 Move modem firmware version check to sara_ncp_client commit ca5cd65 Author: Technobly <[email protected]> Date: Tue Sep 21 17:21:37 2021 -0500 Revert "Remove more R510 FOTA support" This reverts commit 532acce. commit 59b5ec8 Author: Technobly <[email protected]> Date: Mon Sep 20 17:13:28 2021 -0500 Revert "Remove R510 FOTA support" This reverts commit a0b92dd. commit 6ececed Author: Technobly <[email protected]> Date: Fri Sep 17 22:40:41 2021 -0500 Removes System feature FEATURE_NCP_FW_UPDATES and some cleanup commit a78f8c1 Author: Technobly <[email protected]> Date: Fri Sep 10 17:04:29 2021 -0500 Remove R510 support for Gen2 commit 82b8b9f Author: Technobly <[email protected]> Date: Fri Aug 13 09:57:55 2021 -0500 implements System feature FEATURE_NCP_FW_UPDATES and performs NCP FW update in Safe Mode
a1a35cf
to
67d49f3
Compare
Feature
Details
develop-4.x
and reverts the commits which removes FOTA supportR510 FOTA Process
R510 Firmware Update Background Check:
check if there is an update firmware version available.
R510 Firmware Update
a. waiting for final INSTALL URC of 128
b. polling for AT/OK every 10 seconds
c. monitoring a timeout counter of 40 minutes
Testing
Example App
References