-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
System: make sure that the power source being USB host is well detected #2310
base: develop
Are you sure you want to change the base?
Conversation
} else { | ||
src = POWER_SOURCE_UNKNOWN; | ||
// Do not update power source if power is good and in DPDM | ||
if (!pwr_good || !power.isInDPDM()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be this be !power.isInDPDM() && !pwr_good
?
// FIXME: maybe introduce a new flag? | ||
#if HAL_PLATFORM_POWER_WORKAROUND_USB_HOST_VIN_SOURCE | ||
static system_tick_t lastRun = 0; | ||
static uint8_t dpdmRetry = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move these into the class member variables.
if (power.isInDPDM()) { | ||
return; | ||
} | ||
power.enableDPDM(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to cause dips to 100mA current temporarily and may cause for example the modem to brownout if there is no battery attached.
See #2215 for some additional info.
We should probably opt to just reporting USB_HOST
and configuring the PMIC manually as needed (i.e. lowering the input current limit to 500mA) and avoiding re-running DPDM as much as possible.
|
||
if (millis() - lastRun >= DPDM_PERIOD) { | ||
lastRun = millis(); | ||
if (g_powerSource == POWER_SOURCE_VIN && HAL_USB_Get_State(nullptr) >= HAL_USB_STATE_POWERED) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what other states are caught by HAL_USB_Get_State(nullptr) >= HAL_USB_STATE_POWERED
? Can you make this more explicit such as a switch/case statement?
There are cases where the status register is showing 0x24 and the device is being powered through USB. Is there something not configured completely for USB detection? |
Problem
This issue can be easily replicated on Tracker.
VIN
, instead ofUSB Host
If there is a power source attached to the DC jack, pluging back USB cable won't update the power source either.
Solution
When it detects the power source is
VIN
and the USB peripheral is powered, try to run DPDM in the system power management loop to make sure the USB host is correctly reported by PMICSteps to Test
As steps to replicate the issue.
Example App
References
Completeness