Stream definition should be Arduino-compliant #2189
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The definition of
Stream::readBytes
is not fully Arduino-compliant: it should accept both achar*
anduint8_t*
for its buffer pointer. Particle's default compiler settings won't allow the cast to happen automagically, which means some dependent libraries don't compile. Sadness.Solution
Create a function that accepts the missing type and forwards it with an appropriate cast.
Steps to Test
Build
device-os/main
withmake PLATFORM=argon
.References
Thanks to @DavidEGrayson for recommending this fix on pololu/tic-arduino#1.
Completeness