Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify build dependencies #1952

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Conversation

zfields
Copy link
Contributor

@zfields zfields commented Oct 22, 2019

Problem

The DeviceOS needs to describe the dependencies required to build itself in codified documentation.

Solution

Today, the Workbench has delineated the requirements of the DeviceOS in a manifest.json file. As a first step, we shall host this manifest.json file until we are able to describe a more robust enumeration of our dependencies.

Steps to Test

This PR will serve as a test. The PR specifies a feature branch of the buildpack system, which will ultimately consume the new .workbench/manifest.json file. If it is valid, CI will succeed, if it is invalid, then CI will fail

References

Links to the Community, Docs, Other Issues, etc..
https://github.com/particle-iot/buildpack-hal/compare/ch39834/workbench-installer
https://github.com/particle-iot/firmware-buildpack-builder/compare/ch39834/workbench-installer


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@zfields zfields self-assigned this Oct 22, 2019
@zfields zfields force-pushed the ch39834/workbench-installer branch 2 times, most recently from 94892f4 to e184ff7 Compare October 30, 2019 22:24
@zfields zfields changed the title test unified build Describe build dependencies Oct 30, 2019
@zfields zfields force-pushed the ch39834/workbench-installer branch from e184ff7 to 7808102 Compare October 30, 2019 22:45
@m-mcgowan m-mcgowan self-requested a review October 31, 2019 14:44
@zfields zfields force-pushed the ch39834/workbench-installer branch 2 times, most recently from f20566f to b090185 Compare November 14, 2019 05:26
@monkbroc monkbroc requested a review from avtolstoy November 14, 2019 16:40
@zfields zfields force-pushed the ch39834/workbench-installer branch from 800a2b4 to 0cd0a34 Compare November 20, 2019 01:11
@zfields zfields force-pushed the ch39834/workbench-installer branch from 0cd0a34 to 52af5f0 Compare December 2, 2019 14:56
@zfields zfields changed the title Describe build dependencies Unify build dependencies Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants