Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Add ESLint #259

Merged
merged 5 commits into from
Jul 7, 2024
Merged

refactor: Add ESLint #259

merged 5 commits into from
Jul 7, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jul 7, 2024

New Pull Request Checklist

Issue Description

The project is missing a linter. This prevents the developers from following a coding style convention.

Approach

  • Add lint command to CI
  • Suppress console warning in CI
  • Add ESLint 9
  • No functionalilty changes made

@parse-github-assistant Parse GitHub Assistant
Copy link

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@dplewis dplewis requested review from mtrezza and a team July 7, 2024 12:07
mtrezza
mtrezza requested changes Jul 7, 2024
View reviewed changes
.eslintcache Outdated Show resolved Hide resolved
@mtrezza mtrezza merged commit 9e13e9a into parse-community:master Jul 7, 2024
6 checks passed
@dplewis dplewis deleted the eslint branch July 7, 2024 12:55
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dplewis @parseplatformorg @mtrezza