Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add idempotency #1790

Merged
merged 3 commits into from
Jun 17, 2024
Merged

feat: Add idempotency #1790

merged 3 commits into from
Jun 17, 2024

Conversation

dplewis
Copy link
Member

@dplewis dplewis commented Jun 7, 2024

New Pull Request Checklist

Issue Description

Idempotency is a feature on the server to prevent duplicate requests. A unique requestId must be added per request to ensure it works.

parse-community/parse-server#6748

Approach

Add a requestId to every request. This feature must be enabled on the server to work. Add DUPLICATE_REQUEST error code

TODOs before merging

  • Add tests
  • Add changes to documentation (guides, repository pages, in-code descriptions)

Copy link

parse-github-assistant bot commented Jun 7, 2024

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; is this ready for merge? Any more tests that should be added?

@dplewis
Copy link
Member Author

dplewis commented Jun 13, 2024

This is good to merge

@mtrezza mtrezza merged commit dcdf457 into parse-community:master Jun 17, 2024
8 checks passed
parseplatformorg pushed a commit that referenced this pull request Jun 17, 2024
# [4.1.0](4.0.1...4.1.0) (2024-06-17)

### Features

* Add idempotency ([#1790](#1790)) ([dcdf457](dcdf457))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.1.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jun 17, 2024
@dplewis dplewis deleted the idempotency branch July 8, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants