Incremental improvements #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user can decide how often to compute the objective function value and how frequently to test for convergence. This allows to speed up inference significantly by not computing the KL-divergence every iteration for example.
Subsetting the array ran into problems because the dtype of the array did not adjust to longer strings.
flatten does not allow to plot the signatures with their closest matching signatures from a catalog
The annotations of the embedding plot (e.g., the signature names) are now automatically adjusted to prevent overlap. Normalizing the embeddings now projects them onto the hypersphere. This is necessary for (multimodal) CorrNMF, normalizing with the sum without taking absolute values didn't make sense. It might be useful to implement multiple normalization methods in the future.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved: