remove shell redirection for cumulus based collators #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As pointed out here there are some redirections that need to be added. Should we try to push those in 1 commit? |
I think is better to handle those in a follow up pr, did you want to work on that @wirednkod ? |
|
Sure thing @pepoviola |
|
Thanks!! Also, just as ref paras test is failing, I will check what the issue there. |
wirednkod
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1515, fix #1520
NOTE: we should remove the conditional in the near future.
Also, @wirednkod we should review other places where we are using shell redirections.
cc: @JoshOrndorff