Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust export commands to work with cumulus/non-cumulus collators #1520

Closed
pepoviola opened this issue Nov 16, 2023 · 4 comments · Fixed by #1522
Closed

Adjust export commands to work with cumulus/non-cumulus collators #1520

pepoviola opened this issue Nov 16, 2023 · 4 comments · Fixed by #1522
Assignees
Labels

Comments

@pepoviola
Copy link
Collaborator

Take this pr as base #1515.

cc: @JoshOrndorff

@JoshOrndorff
Copy link

Thank you for opening a tracking issue.

#1515 is not related to using non-cumulus collators (although that is absolutely the kind of thing I would support). It is simply a matter of not using shell redirects when you create genesis head data and genesis wasm (and as @wirednkod pointed out some other stuff like chain specs too). This issue affects the normal frame-based Substrate parachain template.

The problem is that if you have any debugging or logging info printed (as developers often like to) it shouldn't corrupt the generated output files.

I'm suggesting you do this:

# Old way that uses shell redirect
parachain-node generate-some-data > result-file

# New way that uses the output argument
parachain-node generate-some-data result-file

I literally just want you to delete the > redirect character.

@pepoviola
Copy link
Collaborator Author

pepoviola commented Nov 16, 2023 via email

@pepoviola pepoviola self-assigned this Nov 16, 2023
@pepoviola
Copy link
Collaborator Author

Just for the record to me, this should be also the behavior in v2.

@JoshOrndorff
Copy link

Here is a PR to Polkadot that updates the adder parachain. I believe this is what you needed to be unblocked? paritytech/polkadot-sdk#2370

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants