-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust export commands to work with cumulus/non-cumulus collators #1520
Comments
Thank you for opening a tracking issue. #1515 is not related to using non-cumulus collators (although that is absolutely the kind of thing I would support). It is simply a matter of not using shell redirects when you create genesis head data and genesis wasm (and as @wirednkod pointed out some other stuff like chain specs too). This issue affects the normal frame-based Substrate parachain template. The problem is that if you have any debugging or logging info printed (as developers often like to) it shouldn't corrupt the generated output files. I'm suggesting you do this: # Old way that uses shell redirect
parachain-node generate-some-data > result-file
# New way that uses the output argument
parachain-node generate-some-data result-file I literally just want you to delete the |
Just to clarify, non-cumulus means adder/undying collators that we use for
internal testing. Those not support the output file option ( I will add it
to them) but we have to make the changes for support both cases.
Thanks!
…On Thu, 16 Nov 2023 at 14:45 Joshy Orndorff ***@***.***> wrote:
Thank you for opening a tracking issue.
#1515 <#1515> is not related
to using non-cumulus collators (although that is absolutely the kind of
thing I would support). It is simply a matter of not using shell redirects
when you create genesis head data and genesis wasm (and as @wirednkod
<https://github.com/wirednkod> pointed out some other stuff like chain
specs too). This issue affects the normal frame-based Substrate parachain
template.
The problem is that if you have any debugging or logging info printed (as
developers often like to) it shouldn't corrupt the generated output files.
I'm suggesting you do this:
# Old way that uses shell redirect
parachain-node generate-some-data > result-file
# New way that uses the output argument
parachain-node generate-some-data result-file
I literally just want you to delete the > redirect character.
—
Reply to this email directly, view it on GitHub
<#1520 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACY3B3RYZACWBAC5VLW6ADYEZGM7AVCNFSM6AAAAAA7OQ65CSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJUHEZTSOJTHA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Parity Technologies is a limited company registered in England and Wales
with registered number 09760015 and registered office at c/o Ignition Law,
1 Sans Walk, London, England, EC1R 0LT. This message is intended solely for
the addressee(s) and may contain confidential information. If you have
received this message in error, please notify us, and immediately and
permanently delete it. Do not use, copy or disclose the information
contained in this message or in any attachment. For information about how
we process data and monitor communications please see our Privacy policy
(https://www.parity.io/privacy/ <https://www.parity.io/privacy/>)and for
terms of use please see our Terms of Use policy
(https://www.parity.io/terms/ <https://www.parity.io/terms/>).
|
Just for the record to me, this should be also the behavior in v2. |
Here is a PR to Polkadot that updates the adder parachain. I believe this is what you needed to be unblocked? paritytech/polkadot-sdk#2370 |
Take this pr as base #1515.
cc: @JoshOrndorff
The text was updated successfully, but these errors were encountered: