Macro for testing all layouts #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there is two kinds of trie layout (with and without extension node), and testing code did add some redundancy.
This pr bring changes done in #81 to avoid this redundancy (#81 brings the number of trie kind to 4).
test_layoutsmacro does launch test for all possible layout.This reduces code size and improve test coverage.
I did also remove
trie_unhashed_no_extfuzzer and some associated function (it is just doing trie root but return an unhashed result).Commit 17eea1a also fix a prefix error that was in an untested (and unused) configuration before.
Fuzzers run on a single layout, using different layout should be done by switching layout into the fuzz_target definition file.