Query plan proofs #196
Open
Query plan proofs #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and then only compact.
- inline node during iteration needing specific suspend feels rather bad and case hard to catch (hash before and inline node but hash are only emmited after). -> generally probably better to switch format to always respect child index order.
|
PR should be ready for review, I did remove the content kind of proof. If it is still a bit too big the compact version could also be removed (yet I think it is very nice to have). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch adds method to create a proof form a set of key value request (following w3f/PPPs#10).
Proof can be split depending on size limits.
To create a splitted proof there is two mode:
Verification is only statefull (for a client there is no sense in obtaining incomplete proof without having all the other part of proofs).
In addition to the psp proof I also implemented the same for compact proof.
The substrate branch using it is https://github.com/cheme/polkadot-sdk/tree/trie_hash (note that no limit is set by default, but this should be configurable for at node start).