-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Derive TypeInfo for own types #72
Open
dvdplm
wants to merge
27
commits into
master
Choose a base branch
from
dp-doogfood
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
84b3bb4
Don't use a feature in the derive crate
dvdplm c2f0f06
Review grumbles
dvdplm b4ba154
Less noise is better: build a TokenStream2 containing the "::" prefix
dvdplm b1d26c2
Use `crate::` when deriving for `scale-info` itself
dvdplm 22fb440
Derive TypeInfo for UntrackedSymbol
dvdplm 00aae34
wip
dvdplm 5a165b1
Add ref to ticket that blocks deriving Typeinfo for Type
dvdplm 9ac6306
Remove TypeInfo impl for MetaType
dvdplm 39f8459
Clippy is right
dvdplm 7db6778
Cleanup
dvdplm 687c757
Merge branch 'master' into dp-doogfood
dvdplm 7f4fae7
Merge branch 'master' into dp-doogfood
dvdplm 1d8ff8c
Merge branch 'master' into dp-doogfood
dvdplm 5c22f19
Remove `NonZero*` impls
dvdplm 58dc3d2
Cleanup
dvdplm e73c061
Don't bind <… as HasCompact>::Type
dvdplm 03bf034
Merge remote-tracking branch 'origin/master' into dp-doogfood
dvdplm c7bfb52
Review grumbles
dvdplm 89d4499
Fix comment
dvdplm 14055e1
Merge branch 'master' into dp-doogfood
dvdplm c7c19fc
Address review feedback
dvdplm d3259c5
fmt
dvdplm 54deaf4
Merge branch 'master' into dp-doogfood
dvdplm 5fd7525
cleanup
dvdplm 2d7530d
Merge branch 'master' into dp-doogfood
gilescope ba2e94a
Fixup after merge
gilescope 3420903
additional support to allow frame-metadata to derive TypeInfo (#163)
gilescope File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to keep this optional crate feature? What purpose does it have?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a good question. I fail to see the reason to keep this as a feature. @ascjones you ok making it non-optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just saw Giles's PR with this stuff in and fwiw I think it doesn't need to be behind a feature flag.