Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pools] New runtime api that returns the pot accounts associated with the pool #6357

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Pools] New runtime api that returns the pot accounts associated with the pool #6357

wants to merge 4 commits into from
+52 −12

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented Nov 5, 2024 •
edited
Loading

closes #6358

Adds the following runtime api to pallet-nomination-pools.
pool_accounts(pool_id): Returns (bonded_account, reward_account) associated with the pool_id.

cc: @rossbulat

@Ank4n Ank4n requested a review from koute as a code owner November 5, 2024 00:52
@Ank4n Ank4n added T2-pallets This PR/Issue is related to a particular pallet. T4-runtime_API This PR/Issue is related to runtime APIs. labels Nov 5, 2024
@Ank4n
Copy link
Contributor Author

Ank4n commented Nov 5, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Nov 5, 2024 •
edited
Loading

@Ank4n https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7693500 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 16-01a67032-ac4b-4d3b-879b-afe5682afae5 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Nov 5, 2024

@Ank4n Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7693500 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7693500/artifacts/download.

@Ank4n Ank4n requested review from gpestana and a team November 5, 2024 01:36
rossbulat
rossbulat approved these changes Nov 5, 2024
View reviewed changes
Copy link

@rossbulat rossbulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, this will help applications a lot 🫡

kianenigma
kianenigma reviewed Nov 5, 2024
View reviewed changes
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to add, but we will probably migrate it to #4722 🙈

we can keep the existing APIs for backwards compatibility for some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@gui1117 gui1117 gui1117 approved these changes

@rossbulat rossbulat rossbulat approved these changes

@koute koute Awaiting requested review from koute koute is a code owner

@gpestana gpestana Awaiting requested review from gpestana

Assignees
No one assigned
Labels
T2-pallets This PR/Issue is related to a particular pallet. T4-runtime_API This PR/Issue is related to runtime APIs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nomination pools Runtime API: Get a pool stash and reward address
4 participants
@Ank4n @kianenigma @gui1117 @rossbulat