[Tx ext stage 2: 1/4] Add TransactionSource as argument in TransactionExtension::validate
#6323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
changed the title
TransactionSource as argument in TransactionExtension::validateTransactionSource as argument in TransactionExtension::validate
gui1117
changed the title
TransactionSource as argument in TransactionExtension::validateTransactionSource as argument in TransactionExtension::validate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meta
This PR is part of 4 PR:
TransactionSourceas argument inTransactionExtension::validate#6323#[pallet::authorize(...)]macro attribute andAuthorizeCallsystem transaction extension #6324#[pallet::authorize(...)]to migrate unsigned in system: tasks + apply_authorized_call #6325#[pallet::authorize(...)]to migrate all unsigned in polkadot-sdk #6326Description
One goal of transaction extension is to get rid or unsigned transactions.
But unsigned transaction validation has access to the
TransactionSource.The source is used for unsigned transactions that the node trust and don't want to pay upfront.
Instead of using transaction source we could do: the transaction is valid if it is signed by the block author, conceptually it should work, but it doesn't look so easy.
This PR add
TransactionSourceto the validate function for transaction extensions