Bump rand version to 0.8 and some other minor changes #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodoufu
changed the title
rodoufu
commented
Apr 25, 2024
| edition = "2018" | ||
| keywords = ["jsonrpc", "json-rpc", "json", "rpc", "serde"] | ||
|
|
||
| [workspace.dependencies] |
There was a problem hiding this comment.
Adding workspace dependencies and also keeping mentions to crates in the workspace in the workspace dependencies.
rodoufu
commented
Apr 25, 2024
| Some(channel) => channel, | ||
| None => break, | ||
| }; | ||
|
|
rodoufu
commented
Apr 25, 2024
| @@ -274,9 +269,9 @@ impl<T: Metadata, S: Middleware<T>> MetaIoHandler<T, S> { | |||
|
|
|||
| let result = match (valid_version, self.methods.get(&method.method)) { | |||
| (false, _) => Err(Error::invalid_version()), | |||
| (true, Some(&RemoteProcedure::Method(ref method))) => Ok(call_method(method)), | |||
rodoufu
commented
Apr 25, 2024
| parking_lot = "0.11.0" | ||
| rand = "0.7" | ||
| serde = "1.0" | ||
| rand = "0.8" |
There was a problem hiding this comment.
Increased rand version from 0.7 to 0.8
rodoufu
commented
Apr 25, 2024
|
|
||
| /// WebSockets Server Error | ||
| #[derive(Debug)] | ||
| pub enum Error { | ||
| /// Io Error | ||
| Io(io::Error), | ||
| /// WebSockets Error | ||
| WsError(ws::Error), | ||
| WsError(Box<ws::Error>), |
There was a problem hiding this comment.
This variant of the enumeration is way larger than the other ones.
|
@sergejparity @mutantcornholio @alvicsam @niklasad1 @TarikGul @dvdplm @paritytech/ci @tomusdrw could someone please take a look whenever you can, and let me know what do you think? |
jayvdb
reviewed
Aug 17, 2024
core-client/Cargo.toml
Outdated
| @@ -27,7 +26,7 @@ arbitrary_precision = ["jsonrpc-client-transports/arbitrary_precision"] | |||
|
|
|||
| [dependencies] | |||
| jsonrpc-client-transports = { version = "18.0.0", path = "./transports", default-features = false } | |||
| futures = { version = "0.3", features = [ "compat" ] } | |||
| futures = { version = "0.3", features = ["compat"] } | |||
There was a problem hiding this comment.
-futures = { version = "0.3", features = ["compat"] }
+futures = { workspace = true, features = ["compat"] }
?
jayvdb
reviewed
Aug 17, 2024
test/Cargo.toml
Outdated
| "jsonrpc-core-client/arbitrary_precision", | ||
| "serde_json/arbitrary_precision", | ||
| "jsonrpc-core/arbitrary_precision", | ||
| ] | ||
|
|
||
| [dev-dependencies] | ||
| jsonrpc-derive = { version = "18.0.0", path = "../derive" } |
There was a problem hiding this comment.
jsonrpc-derive was not in the workspace deps, but I can add it.
jayvdb
reviewed
Aug 17, 2024
test/Cargo.toml
Outdated
Comment on lines
13
to
15
| jsonrpc-core = { version = "18.0.0", path = "../core" } | ||
| jsonrpc-core-client = { version = "18.0.0", path = "../core-client" } | ||
| jsonrpc-pubsub = { version = "18.0.0", path = "../pubsub" } |
jayvdb
reviewed
Aug 17, 2024
stdio/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| futures = "0.3" | ||
| futures.workspace = true | ||
| jsonrpc-core = { version = "18.0.0", path = "../core" } |
jayvdb
reviewed
Aug 17, 2024
server-utils/Cargo.toml
Outdated
|
|
||
| [dependencies] | ||
| bytes = "1.0" | ||
| futures = "0.3" | ||
| futures.workspace = true | ||
| globset = "0.4" | ||
| jsonrpc-core = { version = "18.0.0", path = "../core" } |
|
@jayvdb I have added the changes you asked for. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.