This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
remove without_storage_info from pallet-collective
#2761
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muraca
force-pushed
the
companion/substrate#14355
branch
3 times, most recently
from
7278ae8
to
0c63eec
Compare
12 tasks
muraca
force-pushed
the
companion/substrate#14355
branch
from
0c63eec
to
38c7e05
Compare
juangirini
approved these changes
Jun 26, 2023
juangirini
added
A4-companion
muraca
force-pushed
the
companion/substrate#14355
branch
3 times, most recently
from
5281fda
to
e92ab62
Compare
muraca
commented
Jul 4, 2023
| fn bound_proposal( | ||
| proposal: ProposalOf<T, I>, | ||
| ) -> Result<Bounded<ProposalOf<T, I>>, DispatchError> { | ||
| pallet_preimage::Pallet::<T>::bound(proposal) |
There was a problem hiding this comment.
This is giving an error which can be solved by putting the bound frame_system::Config<Hash = sp_core::H256>, and it is pretty weird since Hash is set as parachains_commons::types::Hash, an alias of sp_core::H256.
There was a problem hiding this comment.
Why do you even need that custom bound_proposal function instead of injecting a StorePreimage trait into the pallet config trait?
muraca
force-pushed
the
companion/substrate#14355
branch
2 times, most recently
from
00e435a
to
68fabb6
Compare
Signed-off-by: muraca <[email protected]>
muraca
force-pushed
the
companion/substrate#14355
branch
from
68fabb6
to
43fe887
Compare
|
The CI pipeline was cancelled due to failure one of the required jobs. |
|
Closed paritytech/substrate#14355 in favor of paritytech/substrate#14585 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
companion for paritytech/substrate#14355