MAINT: use build-in round for df instead of ours #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kegl
reviewed
Jan 24, 2019
There was a problem hiding this comment.
Fine with me, just please make sure that the precisions used for the different score types are not scrambled (a buf that I fixed in the previous PR). Since most of the time we use the same precision for each score type, this is hard to spot. Storm forecast is one where there are different precisions specified for the different columns, just run the starting kit to check if the precisions are used in the right order.
gabriel-hurtado
force-pushed
the
master
branch
from
c970190
to
12512a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting some changes from my previous PR.
We should use the built-in functionalities from pandas in this case.