allow running the react-refresh transformer in custom NODE_ENVs #9977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change means that we will now run the transformer if Parcel was run with a custom environment. We now also exclude CSS files, since they might have a React dependency but they're not script files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Instead of running the transformer only when
NODE_ENV=development, we now only run it as long as the environment is not production.It also explicitly exclude CSS files, since they might have a React dependency but they're not script files. If there's a better way to do this, please let me know!
💻 Examples
Running
NODE_ENV=stg-east parcel --https --port 8080 --host databases.localhostwill create a bundle that, at runtime, will throw the following error:🚨 Test instructions
✔️ PR Todo