Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sd_file_pointer block to correct fseek error #532

Merged
merged 6 commits into from
Jan 17, 2021
Merged

Conversation

zfi
Copy link
Contributor

@zfi zfi commented Jan 17, 2021

This update addresses the remaining issues in Solo-#528. The block 'get' mode returns a properly cast file pointer. The block 'set' mode now properly implements fseek() to position the file pointer relative to the beginning of the file.

Moved the sd_blocks to a new module.

Refactor SD card open to remove extraneous code.
Refactor warning messages into constants to remove duplicate strings.
Replace '\r' with '\n' in code emitter functions.
Add SD File reserved words. Because there are not enough already.

@zfi zfi requested a review from pjewald January 17, 2021 06:26
Copy link
Collaborator

@pjewald pjewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm.

@pjewald pjewald merged commit 3fcf0c1 into release-1.5.7 Jan 17, 2021
@pjewald pjewald deleted the solo-528 branch January 17, 2021 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants