chore: use native conversions for payload to block #13608
Merged
+30
−281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
commented
Dec 31, 2024
Comment on lines
-114
to
-120
|
|
||
| // Non empty ommers | ||
| let block_with_ommers = transform_block(block.clone(), |mut b| { | ||
| b.body.ommers.push(random_header(&mut rng, 100, None).unseal()); | ||
| b | ||
| }); | ||
| assert_matches!( |
There was a problem hiding this comment.
I removed these, because these weren't useful because
we always enforce this
reth/crates/payload/validator/src/lib.rs
Lines 125 to 126 in eebdd0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unlocked now that we're using alloy's block types