Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reth-trie no_std case hashmap #13497

Merged
merged 3 commits into from
Dec 22, 2024
Merged

fix: reth-trie no_std case hashmap #13497

merged 3 commits into from
Dec 22, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 22, 2024

supersedes #13442

Copy link

codspeed-hq bot commented Dec 22, 2024

CodSpeed Performance Report

Merging #13497 will not alter performance

Comparing fix/hashbrown2 (4db9690) with main (2dd0ec3)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main fix/hashbrown2 Change
⁉️ range lookup` 612.4 µs N/A N/A
⁉️ any lookup` 19.9 ms N/A N/A
⁉️ `prefix set preload size: 1000 input size: 997 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 997 Vec with custom cursor lookup`
🆕 range lookup` N/A 609.8 µs N/A
🆕 any lookup` N/A 19.7 ms N/A
🆕 `prefix set preload size: 1000 input size: 998 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 998 Vec with custom cursor lookup`

@mattsse mattsse merged commit f791f39 into main Dec 22, 2024
44 of 45 checks passed
@mattsse mattsse deleted the fix/hashbrown2 branch December 22, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants