Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use NoopConsensus in CLI unwind #13487

Merged
merged 1 commit into from
Dec 22, 2024
Merged

chore: use NoopConsensus in CLI unwind #13487

merged 1 commit into from
Dec 22, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 20, 2024

No description provided.

Copy link

codspeed-hq bot commented Dec 20, 2024

CodSpeed Performance Report

Merging #13487 will improve performances by 14.56%

Comparing klkvr/noop-cons-cli (aa80201) with main (82af170)

Summary

⚡ 2 improvements
✅ 71 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main klkvr/noop-cons-cli Change
🆕 range lookup` N/A 614.9 µs N/A
🆕 any lookup` N/A 19.8 ms N/A
🆕 `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
⁉️ range lookup` 609.7 µs N/A N/A
⁉️ any lookup` 19.6 ms N/A N/A
⁉️ `prefix set preload size: 1000 input size: 995 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 995 Vec with custom cursor lookup`
`receipts root size: 10 HashBuilder` 128.7 µs
ordered_trie_root 148.8 µs 131.5 µs +13.21%

@mattsse mattsse merged commit 2dd0ec3 into main Dec 22, 2024
43 of 44 checks passed
@mattsse mattsse deleted the klkvr/noop-cons-cli branch December 22, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants