-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(root): prefetch account proofs for the block #13431
Open
shekhirin
wants to merge
4
commits into
main
Choose a base branch
from
alexey/state-root-task-prefetch
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,11 @@ | ||
//! State root task related functionality. | ||
|
||
use alloy_primitives::{map::HashSet, Address}; | ||
use alloy_primitives::map::HashSet; | ||
use derive_more::derive::Deref; | ||
use rayon::iter::{ParallelBridge, ParallelIterator}; | ||
use reth_errors::{ProviderError, ProviderResult}; | ||
use reth_evm::system_calls::OnStateHook; | ||
use reth_primitives_traits::{BlockBody, SignedTransaction}; | ||
use reth_provider::{ | ||
providers::ConsistentDbView, BlockReader, DBProvider, DatabaseProviderFactory, | ||
StateCommitmentProvider, | ||
|
@@ -25,7 +26,7 @@ use reth_trie_sparse::{ | |
errors::{SparseStateTrieError, SparseStateTrieResult, SparseTrieError, SparseTrieErrorKind}, | ||
SparseStateTrie, | ||
}; | ||
use revm_primitives::{keccak256, EvmState, B256}; | ||
use revm_primitives::{keccak256, map::AddressHashSet, EvmState, B256}; | ||
use std::{ | ||
collections::BTreeMap, | ||
sync::{ | ||
|
@@ -109,7 +110,7 @@ impl<Factory> StateRootConfig<Factory> { | |
#[allow(dead_code)] | ||
pub enum StateRootMessage<BPF: BlindedProviderFactory> { | ||
/// Prefetch proof targets | ||
PrefetchProofs(HashSet<Address>), | ||
PrefetchProofs(AddressHashSet), | ||
/// New state update from transaction execution | ||
StateUpdate(EvmState), | ||
/// Proof calculation completed for a specific state update | ||
|
@@ -342,11 +343,45 @@ where | |
} | ||
} | ||
|
||
/// Prefetch proofs for the accounts in the provided block. | ||
/// | ||
/// Accounts that will be prefetched are: | ||
/// - Transaction senders | ||
/// - Transaction recipients | ||
/// - Withdrawal recipients | ||
/// | ||
/// This method does not prefetch the proofs on its own, but only sends the message to the | ||
/// [`StateRootTask`] that will be processed by the main loop. | ||
pub fn prefetech_account_proofs< | ||
T: SignedTransaction + alloy_consensus::Transaction, | ||
B: BlockBody<Transaction = T>, | ||
>( | ||
&self, | ||
body: B, | ||
) { | ||
let mut accounts = AddressHashSet::with_capacity_and_hasher( | ||
body.transactions().len() + | ||
body.withdrawals().map_or(0, |withdrawals| withdrawals.len()), | ||
Default::default(), | ||
); | ||
accounts.extend( | ||
body.transactions() | ||
.iter() | ||
.flat_map(|tx| [tx.recover_signer(), tx.kind().to().copied()]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. cuz tis expensive |
||
.flatten(), | ||
); | ||
if let Some(withdrawals) = body.withdrawals() { | ||
accounts.extend(withdrawals.iter().map(|withdrawal| withdrawal.address)); | ||
} | ||
|
||
let _ = self.tx.send(StateRootMessage::PrefetchProofs(accounts)); | ||
} | ||
|
||
/// Handles request for proof prefetch. | ||
fn on_prefetch_proof( | ||
scope: &rayon::Scope<'env>, | ||
config: StateRootConfig<Factory>, | ||
targets: HashSet<Address>, | ||
targets: AddressHashSet, | ||
fetched_proof_targets: &mut MultiProofTargets, | ||
proof_sequence_number: u64, | ||
state_root_message_sender: Sender<StateRootMessage<BPF>>, | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.