feat: add TableSet generic to the node builder pattern
#13231
+53
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandromazza98
requested review from
joshieDo,
rkrasiuk,
rakita,
shekhirin,
mattsse,
Rjected,
fgimenez,
emhane,
onbjerg,
klkvr and
gakonst
as code owners
|
it is also probably needed to change all the references to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #13222
This PR adds the possibility for external users that uses reth as a dependency to create custom tables inside the reth libmdbx database.
You need to overwrite (or wrap) the
EthStorage(orOpStorage) struct and create a new one that implements theTableSettrait. And use that as theStoragetype inside the implementation of theNodeTypestrait.@mattsse